Routing

[s***@gmail.com]

Hi, hackers :)
In /usr/src/sys/netinet/tcp_output.c if function tcp_output() there are code:
error = ip_output(m, tp->t_inpcb->inp_options, NULL,
((so->so_options & SO_DONTROUTE) ? IP_ROUTETOIF : 0), 0,
tp->t_inpcb);
In this function there are only one call ip_output function, but struct route is null.
I think, that more optimaly is to keep the pointer to struct route in tcpcb.And not to search route every time, when tcp_output called.

[Andre Oppermann]

Hi, hackers :) In /usr/src/sys/netinet/tcp_output.c if function tcp_output() there are
code: error = ip_output(m, tp->t_inpcb->inp_options, NULL, ((so->so_options &
SO_DONTROUTE) ? IP_ROUTETOIF : 0), 0, tp->t_inpcb); In this function there are only one
call ip_output function, but struct route is null. I think, that more optimaly is to
keep the pointer to struct route in tcpcb.And not to search route every time, when
tcp_output called.

We had what you describe in FreeBSD prior to version 5.2 and it was a mess.
There were routing table pointers and references all over the place and when
routes changed we had to scan all tcpcb's to nuke old references. Also the
cached host information moved from the routing table to the tcp_hostcache.
While the route loopup per segment send is a very small overhead it outweights
the drawbacks of the previous system quite a bit. And the code is much nicer.